)]}' { "commit": "8750fe58f4bd74a3dd1aeba47ace94907d0a7de5", "tree": "2f1603f6ec6e89c16c2755e16e6bfc01a41c44d5", "parents": [ "8f3234b2c8efc4aea4e49e0b7e03b29131c99662" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Wed Jul 16 10:16:06 2014 -0700" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Wed Jul 16 18:14:32 2014 +0000" }, "message": "base64: fix underflow in EVP_EncodeBlock.\n\nWhen I switched the base64 code to use size_t, I missed that one of the\nloops was counting down, not up, and depended on the loop variable going\nnegative.\n\nAdditionally this change fixes a bug in NETSCAPE_SPKI_b64_encode where\nthe size of the result buffer was incorrectly calculated and a possible\nmemory leak.\n\nChange-Id: Ibdf644244291274f50b314f3bb13a61b46858ca1\nReviewed-on: https://boringssl-review.googlesource.com/1220\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "94c3055c75bf1c3fef0a9406cfbdeda0e1c51dfc", "old_mode": 33188, "old_path": "crypto/base64/base64.c", "new_id": "58e6151b813a3e94b74f0cdbb7973759f0144d83", "new_mode": 33188, "new_path": "crypto/base64/base64.c" }, { "type": "modify", "old_id": "ffadcb4f176b1be7cb65af9c522eafe3d88664c1", "old_mode": 33188, "old_path": "crypto/x509/x509spki.c", "new_id": "243a7d2653a9294183ba7107142a8218f049c1da", "new_mode": 33188, "new_path": "crypto/x509/x509spki.c" } ] }