| commit | d83dcf58c0e28f1837aaeb55ddc2c54c9a1a20ac | [log] [tgz] |
|---|---|---|
| author | Adam Langley <alangley@gmail.com> | Wed Nov 04 11:02:37 2020 -0800 |
| committer | Adam Langley <agl@google.com> | Wed Nov 04 20:15:50 2020 +0000 |
| tree | 8168f245c6fce3205b780bd6cf54ff7d031962fe | |
| parent | aec1b62b07a4465c3b6747a09ad69c614bc5766b [diff] |
runner: explicitly signal error from handshaker. When the handshaker fails to parse a config it currently exits. This causes the two pipes to signal EOF to the shim, but the control channel is a datagram socket in order to be atomic, thus doesn't signal an error. In the shim, EOF on the wfd pipe causes a short loop and thus a hang forever. Catching the EOF and returning an error doesn't work because some tests will close the pipe but still return information over the control channel. We can start a timeout once wfd is closed, but that seems like it might be flakey. Thus this change makes the handshaker send an explicit error over the control channel. It doesn't catch crashes, but it will catch config errors, which are much more common in cross-version tests. Change-Id: I4b1afed17694c57e4713d1b0fa4e9ecb12f09ec5 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43865 Reviewed-by: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: