| commit | 80aa6949756d327476750f9ea2c9700aa2a027c5 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Thu Oct 11 12:40:59 2018 -0500 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu Oct 11 19:53:15 2018 +0000 |
| tree | f88ae2a4f0492c12b0a72ef46589895d0de20549 | |
| parent | 2d98d49cf712ca7dc6f4b23b9c5f5542385d8dbe [diff] |
Always push errors on BIO_read_asn1 failure. This is consistent with the old behavior of d2i_*_fp and avoids tripping Conscrypt's unnecessarily fragile error-handling (see https://github.com/google/conscrypt/pull/552). Additionally, by source inspection, CPython expects ASN1_R_HEADER_TOO_LONG on EOF, analogously to PEM_R_NO_START_LINE. Fix that. The other errors are a bit haphazard in the old implementation (that code is really hard to follow), so I didn't match it too carefully. In particular, OpenSSL would report ASN1_R_HEADER_TOO_LONG on some generic tag parsing, but that is inconsistent with ASN1_R_HEADER_TOO_LONG being an EOF signal. Update-Note: https://boringssl-review.googlesource.com/32106 may have caused some compatibility issues. This should fix it. Change-Id: Idfe2746ffd7733de4338e14c58a40753e98a791e Reviewed-on: https://boringssl-review.googlesource.com/c/32444 Reviewed-by: Steven Valdez <svaldez@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: