Check for allocation failure in x509_name_get_cache

x509_name_get_cache did not check the result of MakeUnique<X509NameCache>().
When that allocation failed, it wrote the name's DER encoding through a null
pointer (CBBFinishArray(cbb.get(), &new_cache->der)) and crashed.

Parsing, encoding, copying, comparing and hashing an X509_NAME all build this
cache (x509_parse_name, x509_marshal_name, x509_name_copy, X509_NAME_cmp,
X509_NAME_hash), so one failed allocation while parsing a certificate
(d2i_X509), in X509_set_issuer_name or in i2d_X509_NAME crashed the process
instead of returning an error. Return nullptr, as the function's other
failure paths do; every caller already handles that.

Reproduced with MALLOC_FAILURE_TESTING: a program that sets a one-entry name
as the issuer and subject of an X509 and encodes the name crashes at three of
its 38 allocations (11, 22 and 33) and handles every failed allocation with
this change.

Change-Id: Ie58d460c422540a9b04ddcaad23811884437a0c6
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/105668
Reviewed-by: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
1 file changed
tree: 85323a53d756e28ceb3ed65a71636d6429ac3905
  1. .agents/
  2. .bcr/
  3. .github/
  4. _agents/
  5. bench/
  6. cmake/
  7. crypto/
  8. decrepit/
  9. docs/
  10. fuzz/
  11. gen/
  12. include/
  13. infra/
  14. pki/
  15. rust/
  16. ssl/
  17. third_party/
  18. tool/
  19. util/
  20. .bazelignore
  21. .bazelrc
  22. .bazelversion
  23. .clang-format
  24. .clang-format-ignore
  25. .clangd
  26. .gitattributes
  27. .gitignore
  28. API-CONVENTIONS.md
  29. AUTHORS
  30. BREAKING-CHANGES.md
  31. BUILD.bazel
  32. build.json
  33. BUILDING.md
  34. CMakeLists.txt
  35. codereview.settings
  36. CONTRIBUTING.md
  37. FUZZING.md
  38. go.mod
  39. go.sum
  40. INCORPORATING.md
  41. LICENSE
  42. MODULE.bazel
  43. MODULE.bazel.lock
  44. PORTING.md
  45. PRESUBMIT.py
  46. PrivacyInfo.xcprivacy
  47. README.md
  48. SANDBOXING.md
  49. SECURITY.md
  50. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: