Include |BN_MONT_CTX| construction in RSA verification speed test.
Change-Id: I30d6560156bedeac781b12c16a65cfede7891bb7
Reviewed-on: https://boringssl-review.googlesource.com/10522
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
diff --git a/tool/speed.cc b/tool/speed.cc
index 5b07921..780a7ea 100644
--- a/tool/speed.cc
+++ b/tool/speed.cc
@@ -147,6 +147,9 @@
TimeResults results;
if (!TimeFunction(&results,
[key, &sig, &fake_sha256_hash, &sig_len]() -> bool {
+ /* Usually during RSA signing we're using a long-lived |RSA| that has
+ * already had all of its |BN_MONT_CTX|s constructed, so it makes
+ * sense to use |key| directly here. */
return RSA_sign(NID_sha256, fake_sha256_hash, sizeof(fake_sha256_hash),
sig.get(), &sig_len, key);
})) {
@@ -158,6 +161,21 @@
if (!TimeFunction(&results,
[key, &fake_sha256_hash, &sig, sig_len]() -> bool {
+ /* Usually during RSA verification we have to parse an RSA key from a
+ * certificate or similar, in which case we'd need to construct a new
+ * RSA key, with a new |BN_MONT_CTX| for the public modulus. If we were
+ * to use |key| directly instead, then these costs wouldn't be
+ * accounted for. */
+ ScopedRSA verify_key(RSA_new());
+ if (!verify_key) {
+ return false;
+ }
+ verify_key->n = BN_dup(key->n);
+ verify_key->e = BN_dup(key->e);
+ if (!verify_key->n ||
+ !verify_key->e) {
+ return false;
+ }
return RSA_verify(NID_sha256, fake_sha256_hash,
sizeof(fake_sha256_hash), sig.get(), sig_len, key);
})) {
