Array::CopyFrom and InPlaceVector::TryCopyFrom: do not allow in to alias this. Also, fix one "theoretical" use-after-free in tls13_enc that happens in the tls13_rotate_traffic_key -> tls13_set_traffic_key call chain by resetting the secret to the same secret we already have. This reads the secret after having called std::destroy_n() on it. This is not detected by asan and msan, as the std::destroy_n() call compiles to nothing when the declared type is a built-in integer type like here (uint8_t). At the same time this means that it also is harmless - at least for now, as long as all types this happens with are POD and as long as std::destroy_n() will keep doing nothing on them. Issue found by asking #Gemini to analyze the code. Change-Id: I65ef3b45a6fd3b394f85c79a658dfc2e6a6a6964 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/90987 Commit-Queue: Xiangfei Ding <xfding@google.com> Reviewed-by: Xiangfei Ding <xfding@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: