Check for PMULL in gcm_sha3_capable This file uses both SHA3 (for EOR3) and PMULL instructions, but it was only checking for the SHA3 bit. This is largely moot because we also, in the caller, check for AES instructions and the Armv8.2 spec currently groups AES and PMULL features together. But, in theory, they could split them up, so we should check this bit too. While I'm here tidy things up: make the ABI tests match the actual code, and name the function eor3 to reference the implementation, not the CPU bit. Change-Id: I7c2788eeaa6a67611647b8218077439a035faafa Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/93468 Reviewed-by: Xiangfei Ding <xfding@google.com> Commit-Queue: David Benjamin <davidben@google.com> Commit-Queue: Xiangfei Ding <xfding@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: