commit 7853619553e20c7ad416b5e53327da2b976596e7
author David Benjamin <davidben@google.com> Fri Apr 17 12:05:16 2020 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Fri Apr 17 16:37:18 2020 +0000
tree 36d064cb46553a69c232233a929d2a0de91ae245
parent 538a124d7073eba59e8841a0b88bc38aa1fe95aa

Match parameter names between header and source.

clang-tidy flagged this in a diff. Running a full clang-tidy would
probably reveal others, but ah well.

Change-Id: Ib004f7df4fd53b326686810c314869b35b35e547
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/40749
Reviewed-by: Steven Valdez <svaldez@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

crypto/fipsmodule/ec/scalar.c

diff --git a/crypto/fipsmodule/ec/scalar.c b/crypto/fipsmodule/ec/scalar.c
index 038e5ff..af055fc 100644
--- a/crypto/fipsmodule/ec/scalar.c
+++ b/crypto/fipsmodule/ec/scalar.c
@@ -132,21 +132,21 @@
 }
 
 int ec_simple_scalar_to_montgomery_inv_vartime(const EC_GROUP *group,
-                                               EC_SCALAR *out,
-                                               const EC_SCALAR *in) {
-  if (ec_scalar_is_zero(group, in)) {
+                                               EC_SCALAR *r,
+                                               const EC_SCALAR *a) {
+  if (ec_scalar_is_zero(group, a)) {
     return 0;
   }
 
   // This implementation (in fact) runs in constant time,
   // even though for this interface it is not mandatory.
 
-  // out = in^-1 in the Montgomery domain. This is
+  // r = a^-1 in the Montgomery domain. This is
   // |ec_scalar_to_montgomery| followed by |ec_scalar_inv0_montgomery|, but
   // |ec_scalar_inv0_montgomery| followed by |ec_scalar_from_montgomery| is
   // equivalent and slightly more efficient.
-  ec_scalar_inv0_montgomery(group, out, in);
-  ec_scalar_from_montgomery(group, out, out);
+  ec_scalar_inv0_montgomery(group, r, a);
+  ec_scalar_from_montgomery(group, r, r);
   return 1;
 }