commit 782d9b6cf7764f6aa2e5e5ffe470431a822c9cc1
author David Benjamin <davidben@google.com> Thu Apr 22 13:01:32 2021 -0400
committer Adam Langley <agl@google.com> Fri Apr 23 23:48:58 2021 +0000
tree fe3b185e5d46e643727cbf3e7cb1edcb394f1317
parent 354cd48f51ea6c6d5c1b1d76ae0585107f8a868e

Const-correct ASN1_OBJECT_create.

The implementation is a little goofy, but OBJ_dup internally makes a
copy of all the data.

Change-Id: I58e6804ede00100211ac112f03e26a34a2d29b5a
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/47125
Reviewed-by: Adam Langley <agl@google.com>

crypto/asn1/a_object.c

diff --git a/crypto/asn1/a_object.c b/crypto/asn1/a_object.c
index bf386dd..1557435 100644
--- a/crypto/asn1/a_object.c
+++ b/crypto/asn1/a_object.c
@@ -263,7 +263,7 @@
         OPENSSL_free(a);
 }
 
-ASN1_OBJECT *ASN1_OBJECT_create(int nid, unsigned char *data, int len,
+ASN1_OBJECT *ASN1_OBJECT_create(int nid, const unsigned char *data, int len,
                                 const char *sn, const char *ln)
 {
     ASN1_OBJECT o;

include/openssl/asn1.h

diff --git a/include/openssl/asn1.h b/include/openssl/asn1.h
index 5e9aa3f..0347d0d 100644
--- a/include/openssl/asn1.h
+++ b/include/openssl/asn1.h
@@ -883,7 +883,8 @@
 OPENSSL_EXPORT int i2t_ASN1_OBJECT(char *buf, int buf_len,
                                    const ASN1_OBJECT *a);
 
-OPENSSL_EXPORT ASN1_OBJECT *ASN1_OBJECT_create(int nid, unsigned char *data,
+OPENSSL_EXPORT ASN1_OBJECT *ASN1_OBJECT_create(int nid,
+                                               const unsigned char *data,
                                                int len, const char *sn,
                                                const char *ln);