| commit | b25140c7b649da3bffc580f21e79e7f14bc83bf3 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Thu Nov 09 15:32:17 2017 -0800 |
| committer | Adam Langley <agl@google.com> | Mon Nov 20 16:18:09 2017 +0000 |
| tree | ce0d5e770e750acae01b148c1cadeba5f9e56ecf | |
| parent | 8db94be1d6459d8a74d76ae30735a21aef237dd6 [diff] |
Fix timing leak in BN_from_montgomery_word. BN_from_montgomery_word doesn't have a constant memory access pattern. Replace the pointer trick with constant_time_select_w. There is, of course, still the bn_correct_top leak pervasive in BIGNUM itself. I wasn't able to measure a performance on RSA operations before or after this change, but the benchmarks would vary wildly run to run. But one would assume the logic here is nothing compared to the actual reduction. Change-Id: Ide761fde3a091a93679f0a803a287aa5d0d4600d Reviewed-on: https://boringssl-review.googlesource.com/22904 Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: