Google Git
Sign in
boringssl / boringssl / 709ba6eef8544cb806350a8e1ef0816aece45a10
commit709ba6eef8544cb806350a8e1ef0816aece45a10[log] [tgz]
authorAdam Langley <agl@imperialviolet.org>Thu Aug 08 20:46:48 2024 +0000
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 08 21:05:20 2024 +0000
tree9a775a7d9bc31a75b389d85d59e7b41ca15f7be5
parentcee4fe2b78cfd2db8b4429b4fefd9831d3e63c04 [diff]
Add virtual destructors.

b7f5443cfc added an abstract class without a virtual destructor, which
is fine in that context, but some places build with -Wnon-virtual-dtor
and thus:

  error: 'bssl::AesHwCipherScorer' has virtual functions but non-virtual destructor

Thus reflect this build configuration in our CMake build and add the
needed lines to satisfy the compiler.

Also put the classes in an anonymous namespace to more strongly hint, if
that is needed, that it can all be optimised down to almost nothing,
which it hopefully is.

Change-Id: Icd51782641073f55d1672dcf6a6adb82e3b27fb4
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/70087
Auto-Submit: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
2 files changed
tree: 9a775a7d9bc31a75b389d85d59e7b41ca15f7be5
  1. .github/
  2. cmake/
  3. crypto/
  4. decrepit/
  5. fuzz/
  6. gen/
  7. include/
  8. pki/
  9. rust/
  10. ssl/
  11. third_party/
  12. tool/
  13. util/
  14. .bazelignore
  15. .bazelrc
  16. .clang-format
  17. .gitignore
  18. API-CONVENTIONS.md
  19. BREAKING-CHANGES.md
  20. BUILD.bazel
  21. build.json
  22. BUILDING.md
  23. CMakeLists.txt
  24. codereview.settings
  25. CONTRIBUTING.md
  26. FUZZING.md
  27. go.mod
  28. go.sum
  29. INCORPORATING.md
  30. LICENSE
  31. MODULE.bazel
  32. MODULE.bazel.lock
  33. PORTING.md
  34. PrivacyInfo.xcprivacy
  35. README.md
  36. SANDBOXING.md
  37. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

There are other files in this directory which might be helpful: