commit 6c4146554837185055a87e46945844aaa55c3359
author David Benjamin <davidben@google.com> Sat Jan 20 07:43:22 2018 -0500
committer Adam Langley <agl@google.com> Fri Feb 02 18:54:09 2018 +0000
tree c50032cbf8ff41344fb8eed9be6ae3c87b8e47e6
parent 7979dbede2757f5c8a00b79afe75618339510457

Remove redundant bn->top computation.

One less to worry about.

Bug: 232
Change-Id: Ib7d38e18fee02590088d76363e17f774cfefa59b
Reviewed-on: https://boringssl-review.googlesource.com/25252
Reviewed-by: Adam Langley <agl@google.com>

crypto/fipsmodule/bn/add.c

diff --git a/crypto/fipsmodule/bn/add.c b/crypto/fipsmodule/bn/add.c
index 201c526..645e647 100644
--- a/crypto/fipsmodule/bn/add.c
+++ b/crypto/fipsmodule/bn/add.c
@@ -199,7 +199,6 @@
 }
 
 int BN_sub(BIGNUM *r, const BIGNUM *a, const BIGNUM *b) {
-  int max;
   int add = 0, neg = 0;
   const BIGNUM *tmp;
 
@@ -232,13 +231,6 @@
     return 1;
   }
 
-  // We are actually doing a - b :-)
-
-  max = (a->top > b->top) ? a->top : b->top;
-  if (!bn_wexpand(r, max)) {
-    return 0;
-  }
-
   if (BN_ucmp(a, b) < 0) {
     if (!BN_usub(r, b, a)) {
       return 0;