)]}'
{
  "commit": "69c26de93c82ad98daecaec6e0c8644cdf74b03f",
  "tree": "c92a390bca8e245e5a9fe2a756660b133712f505",
  "parents": [
    "d4393891414c64a46257bc3d74e794e9d7313f73"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Jan 16 12:59:53 2024 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Jan 16 18:31:44 2024 +0000"
  },
  "message": "Disable the __SHA__ static check for now\n\nhttps://boringssl-review.googlesource.com/c/boringssl/+/64208 caused us\nto skip the runtime check for SHA extensions when SHA is statically\navailable. This change was correct (though we don\u0027t get the size wins\nwithout also emulating -ffunction-sections in the asm file), but we\u0027ve\nrun into a few places where projects build with -march\u003dgoldmont, but\nneed a build that does not require SHA extensions:\n\n- Some CrOS toolchain definitions are incorrect and build with\n  -march\u003dgoldmont when targetting boards that are not Goldmont. b/320482539\n  tracks fixing this.\n\n- Sometimes projects build with -march\u003dgoldmont as a rough optimized\n  baseline. However, Intel CPU capabilities are not strictly linear, so\n  this does not quite work. Some combination of -mtune and\n  -march\u003dx86-64-v{1,2,3,4} would be a better strategy here.\n\n- QEMU versions before 8.2 do not support SHA extensions and disable it\n  with a warning. Projects that target Goldmont and test on QEMU will\n  break. The long-term fix is to update to 8.2. A principled short-term fix\n  would be -march\u003dgoldmont -mno-sha, to reflect that the binary needs to\n  run on both QEMU-8.1-Goldmont and actual-Goldmont.\n\nOther than the CrOS issue, the others have been resolved or at least\nworked around, so once the CrOS issue is fixed, and the changes made\ntheir way through the pipeline, we can try this again. Though with the\nQEMU issue, the longer we wait, the less likely we\u0027ll trip people\nrunning old QEMUs.\n\nBug: b:320482539\nChange-Id: Iab30a441fce313a1413a465f88d7d52cde179292\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65407\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1d9bcd0510de6a6f7cfe5d2639e0b442c23111e4",
      "old_mode": 33188,
      "old_path": "crypto/internal.h",
      "new_id": "25cb106077180469c58aee43b9196a5a0faa979a",
      "new_mode": 33188,
      "new_path": "crypto/internal.h"
    }
  ]
}