)]}' { "commit": "6887d5e81b149d820f68dc04c1e517c410144ec9", "tree": "eeda4bae52d2cc2b0952cb99058a112ae2548f17", "parents": [ "522e2df08903803b4596854aed165e44ea054de1" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Tue Dec 17 13:56:30 2019 -0500" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Fri Dec 20 18:29:26 2019 +0000" }, "message": "Add an option to disable SSE2 intrinsics for testing.\n\nWe have some code which uses SSE2 intrinsics which, since they don\u0027t\nhave complicated build requirements, is enabled even with\nOPENSSL_NO_ASM. x86_64 mandates SSE2 and people building for x86 tend to\nmandate it anyway these days. This is great, but we still have generic\n32-bit and 64-bit code configurations for other platforms.\n\n32-bit generic code is covered by testing 32-bit ARM with NEON disabled.\nHowever, 64-bit ARM always has NEON available, so we have no SIMD-less\n64-bit platforms in our CI.\n\nThe immediate motivation is some bitsliced AES code I\u0027m working on,\nhowever I believe this also applies to the existing HRSS code. This also\nfixes the HRSS feature checks to only look at __SSE2__, not __SSE__.\n__SSE__ isn\u0027t sufficient and we don\u0027t compile if GCC or Clang is told\n-msse -mno-sse2.\n\nChange-Id: Iebb23f1664a2f62e0b4333e0e99f7d5f6c7f384d\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/39204\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "b7f468fe64a759a91eaa7f5047c387a75dead1d5", "old_mode": 33188, "old_path": "CMakeLists.txt", "new_id": "75bf9981b0b6eeae95ca848186bd3c8d1cc10066", "new_mode": 33188, "new_path": "CMakeLists.txt" }, { "type": "modify", "old_id": "4dc3b27feca5fc08606e7e3bb481f9454e3ef828", "old_mode": 33188, "old_path": "crypto/fipsmodule/modes/gcm_nohw.c", "new_id": "f8618b865011d6037056acf653f4d968b253ff11", "new_mode": 33188, "new_path": "crypto/fipsmodule/modes/gcm_nohw.c" }, { "type": "modify", "old_id": "d81a43f62c12a17f21360609821f6b240cfe5c64", "old_mode": 33188, "old_path": "crypto/hrss/hrss.c", "new_id": "0f66e97e640b52921d18620fe49fee551d30ecb4", "new_mode": 33188, "new_path": "crypto/hrss/hrss.c" }, { "type": "modify", "old_id": "1fba5b6672742c8e4095536fafa296f744134d25", "old_mode": 33188, "old_path": "crypto/internal.h", "new_id": "b75f9afe304ba2769ab0511885e052a539df2f32", "new_mode": 33188, "new_path": "crypto/internal.h" } ] }