)]}'
{
  "commit": "6810f0e83aeb2f11599f192335eec9577678e03e",
  "tree": "9165209d2283590f4cc03e66951ee0df5d37745f",
  "parents": [
    "fa2d3d56b9f542f8519b1c2298213d92eb954f3c"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sat Apr 03 02:55:02 2021 -0400"
  },
  "committer": {
    "name": "Adam Langley",
    "email": "agl@google.com",
    "time": "Thu Apr 08 16:29:44 2021 +0000"
  },
  "message": "runner: Ensure helloBytes is always the same as hello.marshal().\n\nThe client handshake currently defers creating the finishedHash and\nwriting things into the transcript, which is a little annoying for ECH.\nIn preparation for simplifying that, one nuisance is that we retain both\nhello and helloBytes, across a long span of code. helloBytes is *almost*\nthe same as hello.marshal() except:\n\n- When we send a V2ClientHello, helloBytes records that we serialized\n  the ClientHello completely differently.\n\n- For the JDK11 workaround tests, helloBytes records that we swapped out\n  the ClientHello entirely.\n\n- By the time we finally write helloBytes into the transcript, hello may\n  have been updated to the second ClientHello.\n\nThis CL resolves the first two issues. It replaces the v2ClientHelloMsg\nwith an option when serializing the clientHelloMsg, and it has the\nClientHello replacement function return a clientHelloMsg instead of a\n[]byte. (This is a little weird because we\u0027re conflating parsed and\nconstructed ClientHellos, but ah well.)\n\nA follow-up CL will remove the differed transcript bits and we\u0027ll\nactually be able to drop helloBytes.\n\nChange-Id: Ib82ac216604e2c4bf421277e57aa5fd3b4cef161\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46629\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "116e2beccc64e256c2fea781b80cd2e08653307d",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/handshake_client.go",
      "new_id": "6ba4e4b10d417a861a120f6c528f12dbaf3e0e91",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/handshake_client.go"
    },
    {
      "type": "modify",
      "old_id": "121244c0d128d3654c47a7c44e8a0f6918e6abbe",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/handshake_messages.go",
      "new_id": "158f7c720aea14c4f480babb15a82d60574e5cd5",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/handshake_messages.go"
    }
  ]
}