)]}'
{
  "commit": "676a8022db7bd707fcb201a13203686222494cbc",
  "tree": "259a62e2df12e87386b04cfc1ab6fcb137e5325c",
  "parents": [
    "9e65c3e4d5f8f6bc3074d362d14ce5801a61ad24"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sun Dec 15 15:44:34 2024 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Sun Dec 15 14:03:57 2024 -0800"
  },
  "message": "Remove alignment requirement on ghash-ssse3\n\nhttps://boringssl-review.googlesource.com/c/boringssl/+/74268 broke the\nSSSE3 GHASH fallback because it no longer maintained alignment of\nHtable. We had been relying on the memcpy to copy Htable into something\naligned.\n\nMaintaining the alignment requirement without the memcpy is kind of a\nnuisance because it now leaks into EVP_AEAD_CTX.  Since we don\u0027t have a\ngood way to make caller-allocatable structs aligned, it would mean\nallocating 15 extra bytes and then finding the right position.\n\nBenchmarks shows that the alignment makes no difference on a Intel(R)\nXeon(R) Gold 6154 CPU @ 3.00GHz. Of course, this is artificial because\nthat CPU would never run this code anyway.\n\nI recall adding the alignment requirement because it gave a bit of a\nperf boost on the old Mac Mini 2010 I was testing against, which\nactually is a CPU that would run it. I was able to dig it up, but\napparently I no longer have a keyboard that\u0027s compatible with it. (That\nmachine is also long EOL and cannot even run Chrome\u0027s minimum macOS\nversion. Although its CPU may be representative for older Windows.)\n\nRegardless, I don\u0027t think it makes sense to expend this complexity for\nthis. (See internal Chrome UMA Net.QuicSession.PreferAesGcm on Windows\nfor the percentage of Windows that would be running this code. Though\nthey should also be using ChaCha20-Poly1305 anyway.)\n\nBug: 42290477\nChange-Id: I4ef8c636bfc18200869f011ea50cc5d4988244ba\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74327\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "346cd8b0a6cab56be3508dfa985c8ee3e7d42b0b",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/cipher/e_aes.cc.inc",
      "new_id": "a9d8960621ce3b5246f10f58dcc5053636ee8d8e",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/cipher/e_aes.cc.inc"
    },
    {
      "type": "modify",
      "old_id": "045c6cbaf7e4cffa6bc8302e96c43f145a15f35d",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/modes/asm/ghash-ssse3-x86.pl",
      "new_id": "793c94f9cbac2da02c7caa9ebbcd0ac577f73afa",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/modes/asm/ghash-ssse3-x86.pl"
    },
    {
      "type": "modify",
      "old_id": "e7590b49cf5b24015f4874e39ecca841c6ad74cf",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/modes/asm/ghash-ssse3-x86_64.pl",
      "new_id": "20a2abbee4278950182788d1d0cde4883ca50305",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/modes/asm/ghash-ssse3-x86_64.pl"
    },
    {
      "type": "modify",
      "old_id": "187812104711c0958f7f16423254af1b79a9b9d4",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/modes/internal.h",
      "new_id": "a77aaea0b94e454d541ea800ecc6100d31af704d",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/modes/internal.h"
    },
    {
      "type": "modify",
      "old_id": "24b1f2f30972478b489d64cf46e75d9b6d81fdd0",
      "old_mode": 33188,
      "old_path": "gen/bcm/ghash-ssse3-x86-apple.S",
      "new_id": "96cb86f06785f2907e707c64fb0e4ee93956e01c",
      "new_mode": 33188,
      "new_path": "gen/bcm/ghash-ssse3-x86-apple.S"
    },
    {
      "type": "modify",
      "old_id": "445db3b4f79f6f858ded1855e4b694c66f9cff5d",
      "old_mode": 33188,
      "old_path": "gen/bcm/ghash-ssse3-x86-linux.S",
      "new_id": "7fe65e76bf885dba0dfe99513d9ef00854f8b0aa",
      "new_mode": 33188,
      "new_path": "gen/bcm/ghash-ssse3-x86-linux.S"
    },
    {
      "type": "modify",
      "old_id": "52108aacc124bcba3c829870edff85020f158004",
      "old_mode": 33188,
      "old_path": "gen/bcm/ghash-ssse3-x86-win.asm",
      "new_id": "201ef5751dd05cbd2e255c9184fd55bfe7ccee2c",
      "new_mode": 33188,
      "new_path": "gen/bcm/ghash-ssse3-x86-win.asm"
    },
    {
      "type": "modify",
      "old_id": "bcbf824f4a5bdd0c01872a380697748fffb7f9b9",
      "old_mode": 33188,
      "old_path": "gen/bcm/ghash-ssse3-x86_64-apple.S",
      "new_id": "651cca321d19df40b8e75ffe97b7f5d44fe7b400",
      "new_mode": 33188,
      "new_path": "gen/bcm/ghash-ssse3-x86_64-apple.S"
    },
    {
      "type": "modify",
      "old_id": "2acb448953a7dada3923020baaa04a2fc5917293",
      "old_mode": 33188,
      "old_path": "gen/bcm/ghash-ssse3-x86_64-linux.S",
      "new_id": "84ac20adf593838f32ba64c52986257b8c6b0947",
      "new_mode": 33188,
      "new_path": "gen/bcm/ghash-ssse3-x86_64-linux.S"
    },
    {
      "type": "modify",
      "old_id": "e0de9624380ebdaca1da1759a642a88915441051",
      "old_mode": 33188,
      "old_path": "gen/bcm/ghash-ssse3-x86_64-win.asm",
      "new_id": "c00e039176ca4440081eeb47654abfe8b3d21e87",
      "new_mode": 33188,
      "new_path": "gen/bcm/ghash-ssse3-x86_64-win.asm"
    }
  ]
}