Remove inconsistent null pointer checks in cipher_update hooks None of the other cipher_update functions have this. They don't make sense here. The weird null special cases are handled in the wrapper layer. For empty slices, the check is wrong, because doing nothing should succeed. It's fine because the wrappers handle empty slices for you. That leaves people incorrectly passing a null pointer with a non-empty slice. But invalid slices are, in general, not something functions can handle. It's unlikely that anyone is relying on this to mask a bug since it is only applied to a couple obscure ciphers. This removes some of the few places where cipher_update is actually fallible. Change-Id: I335a0431370ffd0aa161c866b2fc9cfda2d845eb Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/99988 Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: Rudolf Polzer <rpolzer@google.com> Reviewed-by: Rudolf Polzer <rpolzer@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: