Google Git
Sign in
boringssl / boringssl / 4972efd0f964c3ae5de5085b7cfaecfb3f44833d
commit4972efd0f964c3ae5de5085b7cfaecfb3f44833d[log] [tgz]
authorDavid Benjamin <davidben@google.com>Mon Jan 22 12:14:57 2024 -0500
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 22 17:44:07 2024 +0000
treea01b478632bb1c66742d6cb8b6cf6f1fa177dbcd
parentf42be90d665b6a376177648ccbb76fbbd6497c13 [diff]
Use four-iterator std::equal for bssl::Span::operator==

At one point we targetted C++11 and had to use the unsafe three-iterator
std::equal. Then we had to write the loop by hand because the pragma to
suppress an MSVC warning did not work:
https://boringssl-review.googlesource.com/c/boringssl/+/18384

We now target C++14, so just use the four-iterator version. libc++
will then be able to specialize it into a memcmp call.

Also replace a three-iterator std::equal in pki/input.cc.

Change-Id: I0a7d6a2330594e383c5c884632de9a21a137054c
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65647
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
2 files changed
tree: a01b478632bb1c66742d6cb8b6cf6f1fa177dbcd
  1. .github/
  2. cmake/
  3. crypto/
  4. decrepit/
  5. fuzz/
  6. include/
  7. pki/
  8. rust/
  9. ssl/
  10. third_party/
  11. tool/
  12. util/
  13. .clang-format
  14. .gitignore
  15. API-CONVENTIONS.md
  16. BREAKING-CHANGES.md
  17. BUILDING.md
  18. CMakeLists.txt
  19. codereview.settings
  20. CONTRIBUTING.md
  21. FUZZING.md
  22. go.mod
  23. go.sum
  24. INCORPORATING.md
  25. LICENSE
  26. PORTING.md
  27. README.md
  28. SANDBOXING.md
  29. sources.cmake
  30. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

There are other files in this directory which might be helpful: