| commit | 66e106026aa6efb7e7266d5fd36ef27f30757d43 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Jul 19 16:44:30 2019 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Fri Jul 19 21:34:34 2019 +0000 |
| tree | 52643f2deb565e954250ff9c21642c168728a7e6 | |
| parent | 07432f325d6a388fe6d4881e84b076610c961f05 [diff] |
Align TLS 1.3 cipher suite names with OpenSSL. There are two naming conventions for TLS cipher suites, the standard IETF names (SSL_CIPHER_standard_name) and the ad-hoc OpenSSL names (SSL_CIPHER_get_name). When we added TLS 1.3, we had to come up with OpenSSL-style names for the cipher suites. OpenSSL-style names use hyphens rather than underscores (and omit underscores in odd places), so the natural name for TLS_AES_128_GCM_SHA256 would have been "AES128-GCM-SHA256". However, that name is already taken by TLS_RSA_WITH_AES_128_GCM_SHA256 because OpenSSL's naming convention treats the legacy RSA key exchange as default. Instead, we used an "AEAD-" prefix to indicate the ciphers only specified the AEAD. Since then, OpenSSL has implemented TLS 1.3. Instead, they simply made the OpenSSL-style name match the standard name starting TLS 1.3, underscores and all. (This is why openssl s_client will return very different-looking cipher names in TLS 1.2 and TLS 1.3.) Align with OpenSSL and do the same. Update-Note: SSL_CIPHER_get_name will return different values for TLS 1.3 ciphers than before. Note that we did not allow TLS 1.3 ciphers to be configured at all, so no cipher suite configurations will need to change, but code logging or asserting on the result of a TLS connection may observe differences. It is also recommended that consumers replace uses of SSL_CIPHER_get_name with SSL_CIPHER_standard_name which gives a much more consistent naming convention. (BoringSSL supports both standard and OpenSSL names in the cipher suite configuration, so there's no need to use OpenSSL names at all.) Change-Id: I40b1de0689dd7b32af88602acc063934f2877999 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/36764 Commit-Queue: David Benjamin <davidben@google.com> Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: