| commit | e1d209d4432846d28c31d84f269f4edcb9a63509 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Apr 17 11:57:44 2024 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 17 22:07:27 2024 +0000 |
| tree | fe7138085a1fd0a65c68cc8d535f13fdd24919d5 | |
| parent | 9cac8a6b38c1cbd45c77aee108411d588da006fe [diff] |
Send a consistent alert when the peer sends a bad signature algorithm I noticed that runner tests had a very weird test expectation on the alerts sent around sigalg failures. I think this was an (unimportant) bug on our end. If the peer picks a sigalg that we didn't advertise, we send illegal_parameter. However, it if picks an advertised sigalg that is invalid in context (protocol version, public key), we end up catching it very late in ssl_public_key_verify (by way of setup_ctx) and sending decrypt_error. Instead, have tls12_check_peer_sigalg check this so we consistently send illegal_parameter. (Probably this should all fold into ssl_public_key_verify with an alert out_param, but so it goes.) Change-Id: I09fb84e9c1ee39b2683fa0b67dd6135d31f51c97 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/69367 Commit-Queue: Bob Beck <bbe@google.com> Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: