commit 662bfad81002086c217a9042ed459efd5e0bf82c
author David Benjamin <davidben@google.com> Tue Sep 15 15:22:01 2020 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Sep 15 20:25:16 2020 +0000
tree 1d31157875a52b6c21c6cabedae06a34dd7d8bd1
parent 6ad3b46b24ea45afb609a2852f6dc16f52840583

Fix potential leak in bssl::Array::Shrink.

We don't currently use this type anywhere with a nontrivial destructor,
so this doesn't matter right now. But handle this correctly in case we
ever do. (One of these days, we should sort out using the STL and Abseil
in here...)

Change-Id: I6a198ccf87f953cedcdbe658fa508a3b79d47305
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/42825
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>

ssl/internal.h

diff --git a/ssl/internal.h b/ssl/internal.h
index e08505f..750bfe9 100644
--- a/ssl/internal.h
+++ b/ssl/internal.h
@@ -345,6 +345,9 @@
     if (new_size > size_) {
       abort();
     }
+    for (size_t i = new_size; i < size_; i++) {
+      data_[i].~T();
+    }
     size_ = new_size;
   }