| commit | 4a8c05ffe826c61d50fdf13483b35097168faa5c | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Apr 10 19:58:13 2019 -0500 |
| committer | Adam Langley <agl@google.com> | Thu Apr 11 15:33:57 2019 +0000 |
| tree | 5ee35aace51c9e1a1ab5ec0c3a94b1b88b726a84 | |
| parent | 31ef16ac2d2f450a9816c861ce3d9d6f270e1be0 [diff] |
Check key sizes in AES_set_*_key. AES_set_*_key used to call directly into aes_nohw_set_*_key which gracefully handles some NULL parameters and invalid bit sizes. However, we now enable optimized assembly implementations, not all of which perform these checks. (vpaes does not.) This is fine for the internal assembly functions themselves. Such checks are better written in C than assembly, and the calling C code usually already knows the key size. (Indeed aes_ctr_set_key already assumes the assembly functions are infallible.) AES_set_*_key are public APIs, however. The NULL check is silly, but we should handle length-like checks in public APIs. Change-Id: I259ae6b9811ceaa9dc5bd7173d5754ca7079cff8 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/35564 Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: