commit | 64bf8c50a327217c5f56ba6a4d19ba98b1a07788 | [log] [tgz] |
---|---|---|
author | David Benjamin <davidben@google.com> | Fri Jul 22 15:49:45 2022 -0700 |
committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 25 15:49:28 2022 +0000 |
tree | 9c4e702f55e12df8ed0f39c12b990eba6e06d8eb | |
parent | 28883d4d817a6c5ee3806cd9c1ebf9dc7ed51977 [diff] |
Fix an edge case in SSL_write's retry mechanism. This is split out from https://boringssl-review.googlesource.com/c/boringssl/+/47544 just to get the bugfixes and tests out of the way of the refactor. If we trip the SSL_R_BAD_LENGTH check in tls_write_app_data, wnum is set to zero. But wnum should only be cleared on a successful write. It tracks the number of input bytes that have been written to the transport but not yet reported to the caller. Instead, move it to the success return in that function. All the other error paths already set it to something else. Change-Id: Ib22f9cf04454ecdb0062077f183be5070ab7d791 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/53545 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: