commit 61bb3ddfabfb4386820927003cbf91a862893286
author Adam Langley <agl@chromium.org> Fri Jun 20 12:00:00 2014 -0700
committer Adam Langley <agl@chromium.org> Fri Jun 20 13:17:34 2014 -0700
tree 6886c833b9511704261c961ada3e65ac9f2e1ea4
parent ebebf87d6d5668cd2d491aaf40cb2ef5e7479c02

Ensure that x**0 mod 1 = 0.

crypto/bn/bn_test.c

diff --git a/crypto/bn/bn_test.c b/crypto/bn/bn_test.c
index c29aec8..3863799 100644
--- a/crypto/bn/bn_test.c
+++ b/crypto/bn/bn_test.c
@@ -98,6 +98,7 @@
 int test_mod_exp_mont_consttime(BIO *bp, BN_CTX *ctx);
 int test_exp(BIO *bp, BN_CTX *ctx);
 int test_mod_sqrt(BIO *bp, BN_CTX *ctx);
+static int test_exp_mod_zero();
 int test_mod_exp_mont5(BIO *bp, BN_CTX *ctx);
 #if 0
 int test_gf2m_add(BIO *bp);
@@ -251,8 +252,10 @@
   (void)BIO_flush(out);
 
   message(out, "BN_exp");
-  if (!test_exp(out, ctx))
+  if (!test_exp(out, ctx) ||
+      !test_exp_mod_zero()) {
     goto err;
+  }
   (void)BIO_flush(out);
 
   message(out, "BN_mod_sqrt");
@@ -1117,6 +1120,42 @@
   return (1);
 }
 
+/* test_exp_mod_zero tests that x**0 mod 1 == 0. */
+static int test_exp_mod_zero() {
+  BIGNUM a, p, m;
+  BIGNUM r;
+  BN_CTX *ctx = BN_CTX_new();
+  int ret = 0;
+
+  BN_init(&m);
+  BN_one(&m);
+
+  BN_init(&a);
+  BN_one(&a);
+
+  BN_init(&p);
+  BN_zero(&p);
+
+  BN_init(&r);
+  BN_mod_exp(&r, &a, &p, &m, ctx);
+  BN_CTX_free(ctx);
+
+  if (BN_is_zero(&r)) {
+    ret = 1;
+  } else {
+    printf("1**0 mod 1 = ");
+    BN_print_fp(stdout, &r);
+    printf(", should be 0\n");
+  }
+
+  BN_free(&r);
+  BN_free(&a);
+  BN_free(&p);
+  BN_free(&m);
+
+  return ret;
+}
+
 static int genprime_cb(int p, int n, BN_GENCB *arg) {
   char c = '*';
 

crypto/bn/exponentiation.c

diff --git a/crypto/bn/exponentiation.c b/crypto/bn/exponentiation.c
index b51f15f..ac47e4b 100644
--- a/crypto/bn/exponentiation.c
+++ b/crypto/bn/exponentiation.c
@@ -1186,7 +1186,13 @@
 
   bits = BN_num_bits(p);
   if (bits == 0) {
-    ret = BN_one(rr);
+    /* x**0 mod 1 is still zero. */
+    if (BN_is_one(m)) {
+      ret = 1;
+      BN_zero(rr);
+    } else {
+      ret = BN_one(rr);
+    }
     return ret;
   }
   if (a == 0) {