Fix uninitialized warning.
Bug: 207
Change-Id: I57a7f4b0783132965a22ed7ab64f0b839c62c73f
Reviewed-on: https://boringssl-review.googlesource.com/21964
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
diff --git a/ssl/t1_lib.cc b/ssl/t1_lib.cc
index 32a0471..5d85cb0 100644
--- a/ssl/t1_lib.cc
+++ b/ssl/t1_lib.cc
@@ -2187,31 +2187,31 @@
}
// Find the corresponding key share.
- bool found = false;
CBS peer_key;
+ CBS_init(&peer_key, NULL, 0);
while (CBS_len(&key_shares) > 0) {
uint16_t id;
CBS peer_key_tmp;
if (!CBS_get_u16(&key_shares, &id) ||
- !CBS_get_u16_length_prefixed(&key_shares, &peer_key_tmp)) {
+ !CBS_get_u16_length_prefixed(&key_shares, &peer_key_tmp) ||
+ CBS_len(&peer_key_tmp) == 0) {
OPENSSL_PUT_ERROR(SSL, SSL_R_DECODE_ERROR);
return false;
}
if (id == group_id) {
- if (found) {
+ if (CBS_len(&peer_key) != 0) {
OPENSSL_PUT_ERROR(SSL, SSL_R_DUPLICATE_KEY_SHARE);
*out_alert = SSL_AD_ILLEGAL_PARAMETER;
return false;
}
- found = true;
peer_key = peer_key_tmp;
// Continue parsing the structure to keep peers honest.
}
}
- if (!found) {
+ if (CBS_len(&peer_key) == 0) {
*out_found = false;
out_secret->Reset();
return true;