commit 5f5bf6f2107e4feb515493c1d152a8f23f82b29d
author Adam Langley <agl@google.com> Tue Feb 24 13:49:41 2015 -0800
committer Adam Langley <agl@google.com> Thu Mar 05 22:43:43 2015 +0000
tree e810175c9e8d046c570a7e8e68d87d33312b2460
parent 0685b682161bfcfc5a4a0625016529ec86f883c9

Don't add another error to the queue when RSA_private_transform fails.

Some code, sadly, tests the error and the extra error is breaking it.

Change-Id: I89eabadf5d2c5f7dd761030da33dd4c3f2ac8382
Reviewed-on: https://boringssl-review.googlesource.com/3720
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>

crypto/rsa/rsa_impl.c

diff --git a/crypto/rsa/rsa_impl.c b/crypto/rsa/rsa_impl.c
index 349d74f..5927126 100644
--- a/crypto/rsa/rsa_impl.c
+++ b/crypto/rsa/rsa_impl.c
@@ -360,8 +360,7 @@
   }
 
   if (!RSA_private_transform(rsa, out, buf, rsa_size)) {
-      OPENSSL_PUT_ERROR(RSA, sign_raw, ERR_R_INTERNAL_ERROR);
-      goto err;
+    goto err;
   }
 
   *out_len = rsa_size;
@@ -400,7 +399,6 @@
   }
 
   if (!RSA_private_transform(rsa, buf, in, rsa_size)) {
-    OPENSSL_PUT_ERROR(RSA, decrypt, ERR_R_INTERNAL_ERROR);
     goto err;
   }