Support handle poisoning in EVP_Decrypt ops too.

This means that if any function call failed, further calls to
EVP_Decrypt functions will fail too.

This matches the already existing logic for EVP_Encrypt, and serves to
better support code that disregards error checking on any calls but the
final one

Ghidriff notes:
- `EVP_DecryptFinal_ex2`: added poisoning logic
- `EVP_DecryptUpdate_ex`: added poisoning logic
- `EVP_EncryptFinal_ex2`: restructured poisoning logic to poison on
  error, not on startup and unpoison at end
- `EVP_EncryptUpdate_ex`: restructured poisoning logic to poison on
  error, not on startup and unpoison at end

Update-Note: `EVP_CIPHER` decrypt calls now fail if a previous call on
the same context failed before, as it would leave the cipher in an
indeterminate state. Internal tests pass after cl/830352792. Callers
that do need to reuse an already failed context can do so by calling
`EVP_Cipher_InitEx` on it.

Bug: 42290361
Change-Id: I3a9fde436de0c4a03ba189407041b7fc2051b207
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/83447
Auto-Submit: Rudolf Polzer <rpolzer@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
1 file changed
tree: 5b4fcfa5cde3811031e3678bced84bc3b950e785
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .clang-format-ignore
  22. .gitignore
  23. API-CONVENTIONS.md
  24. AUTHORS
  25. BREAKING-CHANGES.md
  26. BUILD.bazel
  27. build.json
  28. BUILDING.md
  29. CMakeLists.txt
  30. codereview.settings
  31. CONTRIBUTING.md
  32. FUZZING.md
  33. go.mod
  34. go.sum
  35. INCORPORATING.md
  36. LICENSE
  37. MODULE.bazel
  38. MODULE.bazel.lock
  39. PORTING.md
  40. PRESUBMIT.py
  41. PrivacyInfo.xcprivacy
  42. README.md
  43. SANDBOXING.md
  44. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: