| commit | 58e533017762cf744e2144fbb0d199020cac23c2 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Sep 24 18:28:50 2024 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 27 21:21:11 2024 +0000 |
| tree | 5c46ef08688f9f98c35a13125503a836473c699b | |
| parent | 40dd94116ba03678226443ba20c5887459c9bf16 [diff] |
Do not implement SSL_get_traffic_secrets for QUIC and DTLS This is implemented by looking at the saved current read and write secrets. That state is used by KeyUpdate and this logic. As part of tidying up the epoch state for DTLS 1.3, I ran into that state because DTLS does not have a single current read/write secret. But it also isn't ideal for QUIC. For QUIC, the problem is that QUIC drives KeyUpdates outside of TLS, but that means we'll just hold on to the initial traffic secrets in memory, which can derive all the rotated ones. So let's for now, just limit this API to TLS. We can decide later whether to also allow it for DTLS (after very carefully defining what the "current" epoch means). I don't think we'd ever allow it for QUIC given how QUIC is intended to work. (This change doesn't actually fix any of the internal storage, just breaks the API that would leak it. Changing the internal storage will be in later CLs.) Bug: 42290608 Change-Id: I5d4b170a5a80a7cc0657a957ae20135d742891d2 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71647 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: David Benjamin <davidben@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: