commit 58745d61afe244a37941d391f5dec3ab08f5cf2c
author David Benjamin <davidben@google.com> Mon May 20 15:48:01 2024 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 20 22:32:40 2024 +0000
tree 53277cb88755d6b6173f01ced3a0372ca5a9b1ac
parent c798e3a54912a1bfbf1c846630e2bb86e9b543a7

Disable DilithiumTest.BitFlips test

This test is very slow. Even BoringSSL's CI got noticeably slower after
it was enabled. It should hopefully be redundant with the test vectors,
supposing the test vectors were generated well.

(The test is still available to be run manually.)

Bug: chromium:341639202
Change-Id: Ica248c6643458988e45e50d5ec80718b5ff4bb5f
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/68627
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>

crypto/dilithium/dilithium_test.cc

diff --git a/crypto/dilithium/dilithium_test.cc b/crypto/dilithium/dilithium_test.cc
index 3918142..b0bb2ed 100644
--- a/crypto/dilithium/dilithium_test.cc
+++ b/crypto/dilithium/dilithium_test.cc
@@ -28,7 +28,8 @@
 #include "./internal.h"
 
 
-TEST(DilithiumTest, BitFlips) {
+// This test is very slow, so it is disabled by default.
+TEST(DilithiumTest, DISABLED_BitFlips) {
   auto encoded_public_key =
       std::make_unique<uint8_t[]>(DILITHIUM_PUBLIC_KEY_BYTES);
   auto priv = std::make_unique<DILITHIUM_private_key>();