)]}'
{
  "commit": "571c3e78bf2aa479c3abdecbd238d6b5381cc788",
  "tree": "11c7eb8375ef4748ce2377826e789216a00c244d",
  "parents": [
    "13da180506b4c0fa3b9232e77167dae4d694bf32"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Fri Jan 08 11:28:53 2021 -0500"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Fri Jan 08 17:06:29 2021 +0000"
  },
  "message": "Use gai_strerrorA on Windows.\n\ngai_strerror is one of the Windows functions which behaves differently\nwhether UNICODE is defined. See\nhttps://docs.microsoft.com/en-us/windows/win32/intl/conventions-for-function-prototypes\n\nCall gai_strerrorA so that we behave consistently in both modes. This\nfixes the build failure in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/2613519.\n\nIt also fixes a type error in the connect BIO (built but not used in\nChromium), which wasn\u0027t noticed because ERR_add_error_data is a variadic\nfunction and untyped. (The type error won\u0027t go out of bounds because\nwe\u0027re interpreting a NUL-terminated WCHAR* as a NUL-terminated char*.\nThe string will be misinterpreted, but it still will be terminated\neither at the NUL WCHAR or, more likely, the upper zero byte of the\nfirst Latin-1 character in the string.)\n\nThe ERR_add_error_data call raises the question of which of our char*\nstrings are UTF-8 and which are the POSIX locale / Windows code page\n(when those are not also UTF-8). This CL doesn\u0027t address this and only\nfixes the character width error. Realistically, calling code tosses\nchar* to printf so often that non-UTF-8 locales are probably a lost\ncause. (Although right now we do not transform any OS error strings, so\ntossing them to printf works fine. The outputs of functions like\nASN1_STRING_to_UTF8, not so much.)\n\nChange-Id: Ie789730658829bde90022605ade2c86b8a65c3de\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44964\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d4209d0f9a047be6a49cc15ff31c5a94309d18c7",
      "old_mode": 33188,
      "old_path": "crypto/bio/socket_helper.c",
      "new_id": "fc751fd4317ddfce4f4df505d42e99b2b86c24c9",
      "new_mode": 33188,
      "new_path": "crypto/bio/socket_helper.c"
    },
    {
      "type": "modify",
      "old_id": "88e91695f0312ecd1ce51b206630536cd19b4072",
      "old_mode": 33188,
      "old_path": "tool/transport_common.cc",
      "new_id": "b985221de9b6a517da0ac015bcb5e63b6decb591",
      "new_mode": 33188,
      "new_path": "tool/transport_common.cc"
    }
  ]
}