Fix beeu_mod_inverse_vartime on aarch64

https://boringssl-review.googlesource.com/c/boringssl/+/51805 added an
aarch64 version of the x86_64 beeu_mod_inverse_vartime. However, it did
not quite get the shift operations right for A and B.

If clz happened to return 64, the SHIFT256 macro bumps into aarch64 only
looking at the bottom 6 bits of the shift operand. That means, instead
of shifting the value, it jumbles the bits up a bit.

Fix this by clamping the shift amount to 63 bits at a time.

(There is nothing significant about how much we clamp the shift. The
file was already trying to clamp the shift to 64 bits, though
unsuccessfully. The x86_64 clamps it to 27 bits, because it needs to
compute the shift amount very differently. Though this does mean that
the Python pseudocode isn't right because it omits clmaping.)

This function is only used in P-256 ECDSA verification (not signing), on
aarch64 non-small builds. Because it still outputs *some* scalar, we do
not believe it (or really most mod inverse math bugs) can be
meaningfully used to forge ECDSA signatures:

Suppose an attacker could find some (msg, r, s) tuple that triggered
this bug and caused ECDSA verification to pass. ECDSA verification only
uses this function to compute inv(s) and afterwards never uses inv or s
again. The bug still outputs some valid scalar, so we have two cases:

Case 1: buggy_inv(s) != 0

Suppose the attacker instead passed (msg, r, correct_inv(buggy_inv(s))
to a correct ECDSA verifier. The correct ECDSA verifier would then
compute s_inv = buggy_inv(s) and then proceed the same as a verifier
with this bug. If that passes, that means the attacker must have been
able to break ECDSA without this bug anyway.

Case 2: buggy_inv(s) = 0

If this bug causes ECDSA verification to proceed with s_inv = 0, this
would bypass the s != 0 check at the start of verification. However, we
would then compute u1 = u2 = 0 and then 0 * pub + 0 * G = infinity.
Extracting the x-coordinate would then fail, so the signature would not
be accepted anyway.

Put another way, ECDSA signatures should simply have been (r, s^-1), not
(r, s). It's less work for the verifier, while both s and s^-1 are
equally easy for a signer to compute.

Change-Id: I91f44b57811f3eddd3f1973a7dc078c48e0329d7
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/93630
Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
5 files changed
tree: 38f808979fb0ff867e076c5c390ef95465c333de
  1. .bcr/
  2. .github/
  3. bench/
  4. cmake/
  5. crypto/
  6. decrepit/
  7. docs/
  8. fuzz/
  9. gen/
  10. include/
  11. infra/
  12. pki/
  13. rust/
  14. ssl/
  15. third_party/
  16. tool/
  17. util/
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-format-ignore
  23. .gitattributes
  24. .gitignore
  25. API-CONVENTIONS.md
  26. AUTHORS
  27. BREAKING-CHANGES.md
  28. BUILD.bazel
  29. build.json
  30. BUILDING.md
  31. CMakeLists.txt
  32. codereview.settings
  33. CONTRIBUTING.md
  34. FUZZING.md
  35. go.mod
  36. go.sum
  37. INCORPORATING.md
  38. LICENSE
  39. MODULE.bazel
  40. MODULE.bazel.lock
  41. PORTING.md
  42. PRESUBMIT.py
  43. PrivacyInfo.xcprivacy
  44. README.md
  45. SANDBOXING.md
  46. SECURITY.md
  47. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: