Google Git
Sign in
boringssl / boringssl / 5386d908a663a424d154cbae7f76f2266c60c2fe
commit5386d908a663a424d154cbae7f76f2266c60c2fe[log] [tgz]
authorBob Beck <bbe@google.com>Tue Apr 08 23:48:17 2025 +0000
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 10 10:02:39 2025 -0700
treebe84e65675e7c6d68fb97300a3e06239477ca6d4
parent5219abf59b071d2b7c454e5827a368d4db97691f [diff]
Fix backward check in crl_crldp_check

I missed this on review and stared at it a few times
before realizing because the "score" code is pretty obtuse.

If we don't have reasons, and we don't have a CRLissuer, we will
have already checked that the signer of the CRL matches the issuer
of the cert (The "Otherwise" part of step b.1), and so we want
to continue to do step b.2. If there is an issuing distribution point
in the crl check to see if one of the names in it matches the names in the
distribution point in the cert.

Fixed: 400486977
Bug: 409778435

Change-Id: I8537450094065d1d465d14e0330f2f0b26d2564f
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78368
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
1 file changed
tree: be84e65675e7c6d68fb97300a3e06239477ca6d4
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .gitignore
  22. API-CONVENTIONS.md
  23. AUTHORS
  24. BREAKING-CHANGES.md
  25. BUILD.bazel
  26. build.json
  27. BUILDING.md
  28. CMakeLists.txt
  29. codereview.settings
  30. CONTRIBUTING.md
  31. FUZZING.md
  32. go.mod
  33. go.sum
  34. INCORPORATING.md
  35. LICENSE
  36. MODULE.bazel
  37. MODULE.bazel.lock
  38. PORTING.md
  39. PrivacyInfo.xcprivacy
  40. README.md
  41. SANDBOXING.md
  42. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: