)]}' { "commit": "5351c8bf3865b85eae085c86338db31ff16dd8c7", "tree": "cfbe585a98b9d79858ffc0b8457d99d3964f93f1", "parents": [ "0a6bfa36c932fbf6bf8d8cc8611d499a6f2d9b5d" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Thu Nov 19 00:25:29 2020 -0500" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Thu Nov 19 13:33:42 2020 +0000" }, "message": "Rename the master_key field in SSL_SESSION to secret.\n\nIt\u0027s not even accurate. The term \"master key\" dates to SSL 2, which we\ndo not implement. (Starting SSL 3, \"key\" was replaced with \"secret\".)\nThe field stores, at various points, the TLS 1.2 master secret, the TLS\n1.3 resumption master secret, and the TLS 1.3 resumption PSK. Simply\nrename the field to \u0027secret\u0027, which is as descriptive of a name as we\ncan get at this point.\n\nI\u0027ve left SSL_SESSION_get_master_key alone for now, as it\u0027s there for\nOpenSSL compatibility, as well as references to the various TLS secrets\nsince those refer to concepts in the spec. (When the dust settles a bit\non rfc8446bis, we can fix those.)\n\nChange-Id: I3c1007eb7982788789cc5db851de8724c7f35baf\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44144\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "933c04a756e02c9f73e49701983a6431168fa037", "old_mode": 33188, "old_path": "include/openssl/ssl.h", "new_id": "68d0b0871519a86c77f4bf01db2f56209dfb6a55", "new_mode": 33188, "new_path": "include/openssl/ssl.h" }, { "type": "modify", "old_id": "66d108e79f5ba3b82ab2c8dfbb058d8dabeecd2a", "old_mode": 33188, "old_path": "ssl/handshake.cc", "new_id": "eb630a5b2d3515905d801bf22f1c7c671946686a", "new_mode": 33188, "new_path": "ssl/handshake.cc" }, { "type": "modify", "old_id": "c36b192a191de0ad0ebd50045ba9e5d021ba2baf", "old_mode": 33188, "old_path": "ssl/handshake_client.cc", "new_id": "59ef6ec5f3b78a9154c611082dc685b1542b8c66", "new_mode": 33188, "new_path": "ssl/handshake_client.cc" }, { "type": "modify", "old_id": "26227d3417773da14e364531203218d4edaf70d9", "old_mode": 33188, "old_path": "ssl/handshake_server.cc", "new_id": "22fa6a1d28dba77873416f774b473046feb88de5", "new_mode": 33188, "new_path": "ssl/handshake_server.cc" }, { "type": "modify", "old_id": "1e54c98dc79aaeef3712daf90931985754c76d1c", "old_mode": 33188, "old_path": "ssl/internal.h", "new_id": "61cbefe84319f2c59d66acc099ff4a75c0e356b4", "new_mode": 33188, "new_path": "ssl/internal.h" }, { "type": "modify", "old_id": "0e913087c9a4e7dece1d95f959f4674f8ed4d6f8", "old_mode": 33188, "old_path": "ssl/ssl_asn1.cc", "new_id": "27bc3103de9df2cf507f4e97af7485005b028811", "new_mode": 33188, "new_path": "ssl/ssl_asn1.cc" }, { "type": "modify", "old_id": "7538a72b28484bb127b0ce56cbcc31ec72598632", "old_mode": 33188, "old_path": "ssl/ssl_session.cc", "new_id": "91b2fff56010599ad6d9e88b4fd560336aeae062", "new_mode": 33188, "new_path": "ssl/ssl_session.cc" }, { "type": "modify", "old_id": "c1cef2bb12e4344836aba92a1b83d83b3d39e6f9", "old_mode": 33188, "old_path": "ssl/ssl_transcript.cc", "new_id": "0bc13b9c2d46f051275eb884c91f123eee53810d", "new_mode": 33188, "new_path": "ssl/ssl_transcript.cc" }, { "type": "modify", "old_id": "d8b6ea2b4d20e6d5c5bc3a824a3bd98df54b7be6", "old_mode": 33188, "old_path": "ssl/t1_enc.cc", "new_id": "c8db457f1c7b0248d96e4e0774dc85f43d5061cb", "new_mode": 33188, "new_path": "ssl/t1_enc.cc" }, { "type": "modify", "old_id": "c77824f8611444fe76061ccfd0b62c7bee31a9d0", "old_mode": 33188, "old_path": "ssl/tls13_client.cc", "new_id": "496ae019f6e8aec8bf12488072e55cbb62a8079b", "new_mode": 33188, "new_path": "ssl/tls13_client.cc" }, { "type": "modify", "old_id": "69a55788cc8230ce19ed1417b150c6dcd9372190", "old_mode": 33188, "old_path": "ssl/tls13_enc.cc", "new_id": "198adb61284461bfd608bbeb7b44beab8384049e", "new_mode": 33188, "new_path": "ssl/tls13_enc.cc" }, { "type": "modify", "old_id": "fefb074b8d101147f28e3a5f43c11d43f506df9a", "old_mode": 33188, "old_path": "ssl/tls13_server.cc", "new_id": "9dfe32536c9046c2d7e7abe77699b50517a9214d", "new_mode": 33188, "new_path": "ssl/tls13_server.cc" } ] }