| commit | 520d211b842079f6343803c9635422a29e9e12df | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Jan 17 17:16:45 2024 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 17 22:49:30 2024 +0000 |
| tree | 347de009a2726035dc83114a8554181b67a4a37f | |
| parent | 313f9b0c6034e3337f50a91466bd8977442bdc21 [diff] |
Fix a bug detecting BER deeply nested inside DER When BER was nested deep inside otherwise valid DER, cbs_find_ber's internally book-keeping would clobber *out_ber_found and lose track that there was some BER to convert. This is unlikely to come up in real world inputs, as the only reason to use any of these awful BER features is to stream the output. I.e., there is no reason to have indefinite-length inside definite-length, and there is no reason to have definite-length constructed string. That means cbs_find_ber, realistically, can just check for indefinite-length encoding at the front and do nothing else. Nonetheless, these inputs are nominally allowed, so fix the book-keeping bug. Change-Id: Idaf3c178fa511ce24af83d6ae27fa9f197f1789e Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65507 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: Bob Beck <bbe@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: