| commit | 5199c7adec3e3f3876a1b84cba909904e2ff48db | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Dec 09 14:13:30 2024 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Dec 09 19:57:14 2024 +0000 |
| tree | 7b897de0d55a33c54f0e0974350ed87f12758a97 | |
| parent | b6eec48a579eff1abe70ce6d480a017d6ca3a32c [diff] |
Fix pointer arithmetic in ASN1_item_ex_free The ASN1_ITYPE_SEQUENCE loop does the 90s C thing where we didn't trust our compilers and manually maintained loop variables as pointers. But since this code is iterating backwards, it ends up creating a one-before-the-start pointer. Unlike the one-past-the-end pointer, this is not legal. It never does anything with this pointer, and the compiler would need to see through quite a few functions to observe this UB, so it is unlikely that this UB had any impact in practice, but we should still fix it. Fix this by writing this code more straightforwardly. In doing so, push variable declarations closer to their use, so it's easier to tell that i is an int. Bug: 382414689 Change-Id: I35fb2d3aba563c5be86aaca29de31f339bfdc297 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74089 Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: