Remove bad PSK binder assert (debug only) The assert was trying to catch us accidentally passing the whole message, instead of just the ClientHello body, into this function. The version of the assert in ssl_add_clienthello_tlsext is fine because we indeed will never write a ClientHello with a bogus version. But we may receive a ClientHello with a bogus version, especially now that version negotiation has moved. Just remove this assert. It was a nice double-check, but the true self-check is that, if we computed the binders wrong, Go tests would fail and we'd notice. Yay for fuzzers. Add a missing test to cover this case. Bug: 369963041 Fixed: 483663239 Change-Id: Ib726f36682235b1d55e497b61a837ad4469fdc4c Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/89267 Commit-Queue: Lily Chen <chlily@google.com> Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Lily Chen <chlily@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: