)]}'
{
  "commit": "4d6b2f971e456962b70e4e91768caffdb36fe016",
  "tree": "bfd0d224ba48180295e25687774f800839e437fb",
  "parents": [
    "16391ed176f1ff9c54b86bb9817b5a27801e870a"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Jun 08 13:43:34 2026 -0400"
  },
  "committer": {
    "name": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Jun 09 07:33:20 2026 -0700"
  },
  "message": "delocate: Treat BORINGSSL_bcm_text_hash as a synthesized symbol\n\nOtherwise the compiler may emit a GOT-based access to it. For some\nreason, that combined with our synthesized symbols not being .globl\nseems to cause the linker to resolve it to a completely random GOT entry\nand get confused? I haven\u0027t fully figured out what\u0027s going on there.\n\nPossibly these symbols should be .globl to support GOT accesses, but\ngiven we don\u0027t want GOT accesses anyway, go ahead and correctly mark\nthem as synthesized symbols so we don\u0027t have this issue. (We probably\ncould have, equivalently, put a hidden visibility attribute on the decls\nin the source code, and then the compiler wouldn\u0027t use the GOT at all.\nBut for now, I\u0027ve kept solving this in the way we\u0027ve solved this\nbefore.)\n\nThis fixes the variant of crbug.com/520369788 I managed to repro, but\nsince the original bug contains insufficient information to reproduce it\n(and what seems like hallucinations), I am not sure whether this\nactually fixes it.\n\nBug: 520369788\nChange-Id: I6b8103550fc2820aba8731e2d19cc2be1114b4e8\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/96887\nPresubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cboringssl-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "cc7e312d7af9eebda81bdbebd7b05682aa71c54f",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/delocate.go",
      "new_id": "fbbeb8bad1b4fab8bc73c9e6c4c1087238113f59",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/delocate.go"
    },
    {
      "type": "modify",
      "old_id": "1e0d4454371cdcb0171b09b4491d1ad848ee147a",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/aarch64-Basic/in.s",
      "new_id": "8f35ec6e9ad8e7543d88351c825408a6e131aba5",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/aarch64-Basic/in.s"
    },
    {
      "type": "modify",
      "old_id": "d92dc1c235404c315af9ecd22b303755de003a58",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/aarch64-Basic/out.s",
      "new_id": "54861a71449097ed8ec52302b9d7d87a6e686034",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/aarch64-Basic/out.s"
    },
    {
      "type": "modify",
      "old_id": "b339896db173ecc51307e5e3e6d3e3c159120579",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/generic-AddrSig/out.s",
      "new_id": "d35303f3a9006f570c368bf053cc88ef10a73cea",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/generic-AddrSig/out.s"
    },
    {
      "type": "modify",
      "old_id": "fa888a9fd5666d17c42796d6d92223332bd8f4a0",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/generic-FileDirectives/out.s",
      "new_id": "f01ecd698846eeb3be9fb1362d9e211a368c6072",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/generic-FileDirectives/out.s"
    },
    {
      "type": "modify",
      "old_id": "0007639d08a67517e62cff348707a1be526d5fc5",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-BSS/out.s",
      "new_id": "ab9e97fd17ebf5aff1cf87e9575ed346ca986485",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-BSS/out.s"
    },
    {
      "type": "modify",
      "old_id": "d0b8d55e65605f5ed8bd57b43ef7784f420d7837",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-Basic/out.s",
      "new_id": "6671ec937e6924667023857acf10014a804f099e",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-Basic/out.s"
    },
    {
      "type": "modify",
      "old_id": "bec92c5beb755203fd4593a385cb8d3a724e2325",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-GOTRewrite/in.s",
      "new_id": "bce3395f184bca39cf4e5395f8214344c25483c8",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-GOTRewrite/in.s"
    },
    {
      "type": "modify",
      "old_id": "fdc730354b87cfec256aa4db3b99d562ed34002f",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-GOTRewrite/out.s",
      "new_id": "acd66544c04406a42eda2bac0470d211473d22ec",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-GOTRewrite/out.s"
    },
    {
      "type": "modify",
      "old_id": "f464225062a949139437100cf58c1f64faebb294",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-LabelRewrite/out.s",
      "new_id": "b7d16d519d581c4bbdc63a752b0d679e1d8399c9",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-LabelRewrite/out.s"
    },
    {
      "type": "modify",
      "old_id": "87c0f4752722df34c60b324663b68970d9c8200d",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-LargeMemory/out.s",
      "new_id": "f067d02f996a822a4552a185e55f8fffc90249b8",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-LargeMemory/out.s"
    },
    {
      "type": "modify",
      "old_id": "2fec054d2a0769e8deb09c3b411385cbf4262bab",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-Sections/out.s",
      "new_id": "679cab26d66914d0b743050e02cf9b5d634a56a7",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-Sections/out.s"
    },
    {
      "type": "modify",
      "old_id": "759a8c69621bd7ecf788b89c317d7c96ad94ffca",
      "old_mode": 33188,
      "old_path": "util/fipstools/delocate/testdata/x86_64-ThreeArg/out.s",
      "new_id": "65801be404e39bd541f55b4436c1bb5357a0997a",
      "new_mode": 33188,
      "new_path": "util/fipstools/delocate/testdata/x86_64-ThreeArg/out.s"
    }
  ]
}
