tree 4961944cd076d1d5cb1fd018aef3b712abf04319
parent 200fe6786b820414444615bb6c2bb09fce90b6c3
author David Benjamin <davidben@google.com> 1544725254 -0600
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1544729449 +0000

Fix thread-safety bug in SSL_get_peer_cert_chain.

https://boringssl-review.googlesource.com/12704 pushed it just too far
to the edge. Once we have an established SSL_SESSION, any modifications
need to either be locked or done ahead of time. Do it ahead of time.
session->is_server gives a suitable place to check and X509s are
ref-counted so this should be cheap.

Add a regression test via TSan. Confirmed that TSan indeed catches this.

Change-Id: I30ce7b757d3a44465b318af3c98961ff3667483e
Reviewed-on: https://boringssl-review.googlesource.com/c/33606
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>