)]}' { "commit": "4ca8d131d316b6f072f546c98c1011bbecb3f8b2", "tree": "56d10a1040d22b970a34ee420012916b9d1a23f2", "parents": [ "c93be52c9ef59801704a80bc39ddcfe3bd4277ed" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Thu Mar 14 19:25:41 2019 -0500" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Mar 18 19:18:31 2019 +0000" }, "message": "Rewrite BN_CTX.\n\nWhile allocating near INT_MAX BIGNUMs or stack frames would never happen, we\nshould properly handle overflow here. Rewrite it to just be a STACK_OF(BIGNUM)\nplus a stack of indices. Also simplify the error-handling. If we make the\nerrors truly sticky (rather than just sticky per frame), we don\u0027t need to keep\ntrack of err_stack and friends.\n\nThanks to mlbrown for reporting the integer overflows in the original\nimplementation.\n\nBug: chromium:942269\nChange-Id: Ie9c9baea3eeb82d65d88b1cb1388861f5cd84fe5\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/35328\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "af50de9398b7193057b63dc29c6233267d889ebb", "old_mode": 33188, "old_path": "crypto/fipsmodule/bn/ctx.c", "new_id": "1926e80be5bf7e9370a672929a9595a628eaa3a3", "new_mode": 33188, "new_path": "crypto/fipsmodule/bn/ctx.c" } ] }