)]}'
{
  "commit": "4ae71a4c7aea7287b7090dfa664bf9a1f30ea787",
  "tree": "8619aaea6c5a1cae4ac8f5404b1efe82a50e5f98",
  "parents": [
    "66feb2c552cd9e09f0d7cfff291ce4842cc1a5a7"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Wed Dec 09 16:42:03 2020 -0500"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Thu Dec 10 20:53:04 2020 +0000"
  },
  "message": "Skip ASN.1 template tests in Windows shared library builds.\n\nThis should fix the Chromium roll.\n\nWindows shared library builds are fussy about dllexport vs. dllimport in\na way that\u0027s incompatible with external uses of the asn1t.h macros. The\nissue is the DECLARE_* macros will add dllexport vs. dllimport on the\nassumption the symbols are defined in libcrypto, but external\ndefinitions need a different selector.\n\nRather than add more complex macros for this, just exclude those tests.\nIdeally we wouldn\u0027t supoport asn1t.h outside the library at all, if we\ncan manage it, so no sense in trying to make it work.\n\nThis excludes both the new and the old tests. Although this has been\nworking thus far, it only works because we\u0027ve been setting the\nBORINGSSL_IMPLEMENTATION symbol for test targets wrong in Chromium. I\u0027m\nconfused how that\u0027s been working at all (maybe dllexport vs. dllimport\nis more lax when it comes to functions rather than variables?), but when\nI do it correctly, the ASN1_LINKED_LIST template breaks too.\n\nChange-Id: I391edba1748f66c383ed55a9d23053674bbb876e\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44484\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "68a062b9be1aacff8d6c8e92dd785e583e7b1886",
      "old_mode": 33188,
      "old_path": "crypto/asn1/asn1_test.cc",
      "new_id": "7b09ba5c4995d912c7fc690b3b55fa3bcdba5034",
      "new_mode": 33188,
      "new_path": "crypto/asn1/asn1_test.cc"
    }
  ]
}