commit 4abd625c6afd099ebd0f1625d012182bdc3c9623
author David Benjamin <davidben@google.com> Sun Dec 07 08:29:06 2025 -0800
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Sun Dec 07 18:07:51 2025 -0800
tree 2a2c3c076b7ce591dd2edf67603dbbcc14918fec
parent 8f8de768dba2a5c1f52125dc74ab9d1f1139c731

Don't condition BORINGSSL_self_test on !_MSC_VER

MSVC seems to compile it just fine now.

Change-Id: I02459d59b93b14bbfa674aa3213615334e5b670f
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/85207
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Xiangfei Ding <xfding@google.com>
Commit-Queue: Xiangfei Ding <xfding@google.com>

crypto/fipsmodule/self_check/self_check.cc.inc

diff --git a/crypto/fipsmodule/self_check/self_check.cc.inc b/crypto/fipsmodule/self_check/self_check.cc.inc
index 13b4e13..300c892 100644
--- a/crypto/fipsmodule/self_check/self_check.cc.inc
+++ b/crypto/fipsmodule/self_check/self_check.cc.inc
@@ -68,14 +68,6 @@
   return 1;
 }
 
-// MSVC wants to put a NUL byte at the end of non-char arrays and so cannot
-// compile the real logic.
-#if defined(_MSC_VER)
-
-int BORINGSSL_self_test(void) { return 0; }
-
-#else
-
 static int set_bignum(BIGNUM **out, const uint8_t *in, size_t len) {
   *out = BN_bin2bn(in, len, nullptr);
   return *out != nullptr;
@@ -1060,5 +1052,3 @@
 #if defined(BORINGSSL_FIPS)
 int boringssl_self_test_startup(void) { return boringssl_self_test_fast(); }
 #endif
-
-#endif  // !_MSC_VER

crypto/self_test.cc

diff --git a/crypto/self_test.cc b/crypto/self_test.cc
index 231fd62..f985fa6 100644
--- a/crypto/self_test.cc
+++ b/crypto/self_test.cc
@@ -18,7 +18,5 @@
 
 
 TEST(SelfTests, KAT) {
-#if !defined(_MSC_VER)
   EXPECT_TRUE(BORINGSSL_self_test());
-#endif
 }