| commit | 4501bd5118eebd54af4066e5eff016064185ba85 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Aug 01 13:39:41 2016 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Aug 02 17:50:39 2016 +0000 |
| tree | 81b6083e7f306cbe2e4bb7208a6e04b7de41c24c | |
| parent | e76cdde77d05e13c4743ce1b5fe102cb4dd30e03 [diff] |
Align with OpenSSL on SSL_set_bio behavior. SSL_set_bio is a nightmare. In f715c423224a292d79ba0e3df373c828fbae29f7, we noticed that, among other problems, SSL_set_bio's actual behavior did not match how SSL_set_rfd was calling it due to an asymmetry in the rbio/wbio handling. This resulted in SSL_set_fd/SSL_set_rfd calls to crash. We decided that SSL_set_rfd's believed semantics were definitive and changed SSL_set_bio. Upstream, in 65e2d672548e7c4bcb28f1c5c835362830b1745b, decided that SSL_set_bio's behavior, asymmetry and all, was definitive and that the SSL_set_rfd crash was a bug in SSL_set_rfd. Accordingly, they switched the fd callers to use the side-specific setters, new in 1.1.0. Align with upstream's behavior and add tests for all of SSL_set_bio's insanity. Also export the new side-specific setters in anticipation of wanting to be mostly compatible with OpenSSL 1.1.0. Change-Id: Iceac9508711f79750a3cc2ded081b2bb2cbf54d8 Reviewed-on: https://boringssl-review.googlesource.com/9064 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: