Google Git
Sign in
boringssl / boringssl / 412b20b0f699938a370a97cc11815b1eb1e0fcb2
commit412b20b0f699938a370a97cc11815b1eb1e0fcb2[log] [tgz]
authorDavid Benjamin <davidben@google.com>Fri Jan 06 13:57:51 2023 -0500
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 06 19:20:43 2023 +0000
treee825d330bddefde0db4a4655e5559a1e6e8f30aa
parent31bad2514d21f6207f3925ba56754611c462a873 [diff]
Use -pthread instead of -lpthread in Bazel.

This seems to work more reliably across platforms. Actually, both seem
to work on Apple platforms, so we probably didn't need the conditions,
while Android seems to only accept -pthread, based on [1].

This also matches Abseil [2], Envoy [3], and a random example in Bazel
documentation [4].

Though, as a counter-example, POSIX seems to prefer -lpthread, not
-pthread, per [5].

[1] https://github.com/grpc/grpc/pull/31938#issuecomment-1370024585
[2] https://github.com/abseil/abseil-cpp/blob/625a18016d6208c6c0419697cb6caa3f23ce31bc/absl/base/BUILD.bazel#L185
[3] https://github.com/envoyproxy/envoy/blob/main/bazel/envoy_binary.bzl#L72
[4] https://bazel.build/tutorials/cpp-use-cases#include-external-libraries
[5] https://github.com/gflags/gflags/issues/176#issuecomment-252243506

Change-Id: I15005bcf4e4b7ebe91a835b8262c5c6434715c3b
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55927
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
1 file changed
tree: e825d330bddefde0db4a4655e5559a1e6e8f30aa
  1. .github/
  2. crypto/
  3. decrepit/
  4. fuzz/
  5. include/
  6. rust/
  7. ssl/
  8. third_party/
  9. tool/
  10. util/
  11. .clang-format
  12. .gitignore
  13. API-CONVENTIONS.md
  14. BREAKING-CHANGES.md
  15. BUILDING.md
  16. CMakeLists.txt
  17. codereview.settings
  18. CONTRIBUTING.md
  19. FUZZING.md
  20. go.mod
  21. go.sum
  22. INCORPORATING.md
  23. LICENSE
  24. OpenSSLConfig.cmake
  25. PORTING.md
  26. README.md
  27. SANDBOXING.md
  28. sources.cmake
  29. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

There are other files in this directory which might be helpful: