Don't skip calling the cleanup hook in EVP_PKEY_CTX when the copy hook fails

This was only reachable from malloc failure. Way back in
https://boringssl-review.googlesource.com/c/boringssl/+/13830 we
imported a change from BoringSSL to stop calling cleanup when
EVP_PKEY_CTX_dup failed. This supposedly fixed a crash (I didn't check
if it did at the time) but instead caused different malloc failures to
leak memory.

Now that all our cleanup functions are just a call to C++ Delete, and we
use C++ scopers for all the fields, the EVP_PKEY_CTX state is in a
consistent enough state to delete all the time anyway.

While I'm here, I've fixed the cleanup functions to all be more
consistent. Some of them reset ctx->data and some of them didn't. It
doesn't matter if we do because the object will be destroyed immediately
afterwards, so I standardized on the shorter pattern.

To review this, check that a failure in the copy hook never leaves the
EVP_PKEY_CTX in a state where the cleanup hook will not safely clean
this up. Note that bssl::Delete, like C++ delete, gracefully handles
nullptr.

Change-Id: I874b953efbef179f1387c0a2b2e0320e6c3ff2e6
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/93627
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Rudolf Polzer <rpolzer@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
4 files changed
tree: e85d1676f77595b8f08211dbb34bcbd5c43fcaa0
  1. .bcr/
  2. .github/
  3. bench/
  4. cmake/
  5. crypto/
  6. decrepit/
  7. docs/
  8. fuzz/
  9. gen/
  10. include/
  11. infra/
  12. pki/
  13. rust/
  14. ssl/
  15. third_party/
  16. tool/
  17. util/
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-format-ignore
  23. .clangd
  24. .gitattributes
  25. .gitignore
  26. API-CONVENTIONS.md
  27. AUTHORS
  28. BREAKING-CHANGES.md
  29. BUILD.bazel
  30. build.json
  31. BUILDING.md
  32. CMakeLists.txt
  33. codereview.settings
  34. CONTRIBUTING.md
  35. FUZZING.md
  36. go.mod
  37. go.sum
  38. INCORPORATING.md
  39. LICENSE
  40. MODULE.bazel
  41. MODULE.bazel.lock
  42. PORTING.md
  43. PRESUBMIT.py
  44. PrivacyInfo.xcprivacy
  45. README.md
  46. SANDBOXING.md
  47. SECURITY.md
  48. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: