)]}' { "commit": "3cadf63c68c26c2f5df2f6f2a1358db4772f0163", "tree": "0abcfdaece1851181e971b532845a68ca91ede7e", "parents": [ "985da09340a79cc35b26123e9b44870ab5dcc12f" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Thu Jan 28 02:58:06 2016 -0500" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Tue Feb 16 23:54:38 2016 +0000" }, "message": "Remove DSA write_params.\n\nThis imports upstream\u0027s ea6b07b54c1f8fc2275a121cdda071e2df7bd6c1 along\nwith a bugfix in 987157f6f63fa70dbeffca3c8bc62f26e9767ff2.\n\nIn an SPKI, a DSA key is only an INTEGER, with the group information in\nthe AlgorithmIdentifier. But a standalone DSAPublicKey is more complex\n(and apparently made up by OpenSSL). OpenSSL implemented this with a\nwrite_params boolean and making DSAPublicKey a CHOICE.\n\nInstead, have p_dsa_asn1.c encode an INTEGER directly. d2i_DSAPublicKey\nonly parses the standalone form. (That code will be replaced later, but\nfirst do this in preparation for rewriting the DSA ASN.1 code.)\n\nChange-Id: I6fbe298d2723b9816806e9c196c724359b9ffd63\nReviewed-on: https://boringssl-review.googlesource.com/7021\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "1e446920b18d86b6cd7e4ab32f2512dddfd8f0c9", "old_mode": 33188, "old_path": "crypto/dsa/dsa.c", "new_id": "2a9524a332f945329c2bbb9e5625a28a420d1856", "new_mode": 33188, "new_path": "crypto/dsa/dsa.c" }, { "type": "modify", "old_id": "b6b3fa4de09f668070cceab1b36790be2ede0e0c", "old_mode": 33188, "old_path": "crypto/dsa/dsa_asn1.c", "new_id": "4df561d6fe76d0b97be69ed141880bea2465583f", "new_mode": 33188, "new_path": "crypto/dsa/dsa_asn1.c" }, { "type": "modify", "old_id": "a876eef4852be696704a453f75aedf10701bab6e", "old_mode": 33188, "old_path": "crypto/evp/p_dsa_asn1.c", "new_id": "bb68d20ec2ccb8044a815e64efb5f57849bee6ec", "new_mode": 33188, "new_path": "crypto/evp/p_dsa_asn1.c" }, { "type": "modify", "old_id": "1cf8489d576155e9c9c4fef1f4e4e733b0cc9019", "old_mode": 33188, "old_path": "include/openssl/dsa.h", "new_id": "df74bb78733cf803af8f0bdf48ecc4d3b80b5fcf", "new_mode": 33188, "new_path": "include/openssl/dsa.h" } ] }