tree 25e77d263aea60835b6db149b8a4dbe8c600a6fa
parent e2b7bb72216e88b8238083af63c3ecb244e79891
author David Benjamin <davidben@google.com> 1618263803 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1618334666 +0000

Rearrange key share and early data logic.

We currently determine whether we need HelloRetryRequest at the same
time as resolving key share machinery. That is a little too late for
early data negotiation, so we end up accepting early data and then
clearing it later on in the function. This works but is easy to mess up,
given the preceding CL. There's also some ALPS logic that got this
wrong, but I believe it didn't result in any incorrect behavior.

Instead, this pulls secret computation out of the key_share helper
function, which now just finds the matching key share. We then check
early whether we need HRR, before deciding on early data.

Change-Id: I108865da08addfefed4a7db73c60e11cf4335093
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46765
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>