)]}'
{
  "commit": "3b8c5ec1f6dfac6b1aa5a060990216819ff298a7",
  "tree": "25e77d263aea60835b6db149b8a4dbe8c600a6fa",
  "parents": [
    "e2b7bb72216e88b8238083af63c3ecb244e79891"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Apr 12 17:43:23 2021 -0400"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Tue Apr 13 17:24:26 2021 +0000"
  },
  "message": "Rearrange key share and early data logic.\n\nWe currently determine whether we need HelloRetryRequest at the same\ntime as resolving key share machinery. That is a little too late for\nearly data negotiation, so we end up accepting early data and then\nclearing it later on in the function. This works but is easy to mess up,\ngiven the preceding CL. There\u0027s also some ALPS logic that got this\nwrong, but I believe it didn\u0027t result in any incorrect behavior.\n\nInstead, this pulls secret computation out of the key_share helper\nfunction, which now just finds the matching key share. We then check\nearly whether we need HRR, before deciding on early data.\n\nChange-Id: I108865da08addfefed4a7db73c60e11cf4335093\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46765\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9c048bb9b3743a8281b38c9c0479161c2d997ed1",
      "old_mode": 33188,
      "old_path": "ssl/internal.h",
      "new_id": "7a3979bb94d5ad828c9fcb054960ec301a5f2d48",
      "new_mode": 33188,
      "new_path": "ssl/internal.h"
    },
    {
      "type": "modify",
      "old_id": "4216fcd89db316d10a5dcf0c5b8e91165b1b9988",
      "old_mode": 33188,
      "old_path": "ssl/t1_lib.cc",
      "new_id": "20517c41364b392184d4847c2362e2d216c86185",
      "new_mode": 33188,
      "new_path": "ssl/t1_lib.cc"
    },
    {
      "type": "modify",
      "old_id": "adc9d39a20938445e285c85e15d2c6db988022dc",
      "old_mode": 33188,
      "old_path": "ssl/tls13_server.cc",
      "new_id": "b4f5297ede7170a34921897f75c60a35bbd96ce9",
      "new_mode": 33188,
      "new_path": "ssl/tls13_server.cc"
    }
  ]
}