tree 9a16097e7a152a3b900cf7599ce7a0bd0e4c26c8
parent 6d904d5b8aa3b30f1b632b0e4713260543df5d42
author David Benjamin <davidben@google.com> 1602267126 -0400
committer Adam Langley <agl@google.com> 1602277604 +0000

Fix crash when flushing an SSL BIO.

OpenSSL synchronizes bio->next_bio and ssl->rbio with a variety of
callbacks, so BIO_copy_next_retry worked. We do not, so attempting to
flush the BIO crashed.

The SSL BIO is a compatibility hack and intentionally much more limited,
so start by just copying things from the right BIO directly. Add a basic
unit test for SSL BIOs. If we need to, we can implement a more complex
synchronization later.

Additionally reject reconfiguring an SSL BIO because that will leak the
object right now.

Change-Id: I724c95ab6f1a3a1aa1889b0483c81ce3bdc534ae
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43424
Reviewed-by: Adam Langley <agl@google.com>