)]}' { "commit": "384d0eaf1930af1ebc47eda751f0c78dfcba1c03", "tree": "07240432812c76ed9c0a151552735bebc0b78efd", "parents": [ "ffbf95ad41086b116111aea9404230f56fd19311" ], "author": { "name": "Steven Valdez", "email": "svaldez@google.com", "time": "Tue Nov 06 10:45:36 2018 -0500" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Nov 06 19:04:48 2018 +0000" }, "message": "Make SSL_get_current_cipher valid during QUIC callbacks.\n\nUpdate-Note: This effectively reverts https://boringssl-review.googlesource.com/4733,\nwhich was an attempt at a well-defined story during renegotiation and pre-handshake.\nThis is a behavior change, though one that matches OpenSSL upstream. It is also more\nconsistent with other functions, such as SSL_get_curve_id. Renegotiation is now\nopt-in, so this is less critical, and, if we change the behavior mid-renegotiation,\nwe should do it consistently to all getters.\n\nChange-Id: Ica6b386fb7c5ac524395de6650642edd27cac36f\nReviewed-on: https://boringssl-review.googlesource.com/c/32904\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nCQ-Verified: CQ bot account: commit-bot@chromium.org \u003ccommit-bot@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "0fa10b5690caec62b4ab629d2be5901c3b56ac91", "old_mode": 33188, "old_path": "include/openssl/ssl.h", "new_id": "17153c20c139c074063d4ead3c8cfa71d875a344", "new_mode": 33188, "new_path": "include/openssl/ssl.h" }, { "type": "modify", "old_id": "5bd24426e2d640931b2d16b298ae5df2fbca135e", "old_mode": 33188, "old_path": "ssl/ssl_lib.cc", "new_id": "fd560ffbd8b7b8be8225c561c881770318faa116", "new_mode": 33188, "new_path": "ssl/ssl_lib.cc" }, { "type": "modify", "old_id": "14b85d49585ce23c45af74397268ac19311f60fc", "old_mode": 33188, "old_path": "ssl/ssl_test.cc", "new_id": "f945898d03802a897f5b95f201cc5bebc8d1a4c0", "new_mode": 33188, "new_path": "ssl/ssl_test.cc" }, { "type": "modify", "old_id": "ef24ca000e808f87b492c65650b95d0d304c2b27", "old_mode": 33188, "old_path": "ssl/test/test_config.cc", "new_id": "52e6cf76d37691c93379e34653d2adb34bbed2f9", "new_mode": 33188, "new_path": "ssl/test/test_config.cc" } ] }