commit | 37646838e9bb62a0d9d506b117193611c4c46012 | [log] [tgz] |
---|---|---|
author | Adam Langley <agl@google.com> | Mon Aug 01 16:16:46 2016 -0700 |
committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu Aug 18 20:37:10 2016 +0000 |
tree | 446bc2d96b600cfc75cf4a2339764674bcaf3165 | |
parent | 867bcba05df254c0ecdcb58ebbfddfa303e88d28 [diff] |
Have |SSL_get_verify_result| return |X509_V_OK| when no client certificate is given. 9498e74 changed the default value of verify_result to an error. This tripped up NGINX, which depends on a bug[1] in OpenSSL. netty-tcnative also uses this behavior, though it currently isn't tripped up by 9498e74 because it calls |SSL_set_verify_result|. However, we would like to remove |SSL_set_verify_result| and with two data points, it seems this is behavior we must preserve. This change sets |verify_result| to |X509_V_OK| when a) no client certificate is requested or b) none is given and it's optional. [1] See BUGS in https://www.openssl.org/docs/manmaster/ssl/SSL_get_verify_result.html Change-Id: Ibd33660ae409bfe272963a8c39b7e9aa83c3d635 Reviewed-on: https://boringssl-review.googlesource.com/9067 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: